Skip to content

Commit

Permalink
fix(a11y): ignore false positive a11y warnings (#1522)
Browse files Browse the repository at this point in the history
Fixes #1517
  • Loading branch information
metonym authored Oct 14, 2022
1 parent 5723ffe commit c6373dc
Show file tree
Hide file tree
Showing 21 changed files with 24 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"rollup-plugin-terser": "^7.0.2",
"sass": "^1.49.11",
"sveld": "^0.17.2",
"svelte": "^3.50.0",
"svelte": "^3.51.0",
"svelte-check": "^2.8.1",
"typescript": "^4.7.4"
},
Expand Down
1 change: 1 addition & 0 deletions src/CodeSnippet/CodeSnippet.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@
on:mouseenter
on:mouseleave
>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div
role="{type === 'single' ? 'textbox' : undefined}"
tabindex="{type === 'single' && !disabled ? '0' : undefined}"
Expand Down
1 change: 1 addition & 0 deletions src/ComposedModal/ComposedModal.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@
}
}}"
>
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
bind:this="{innerModal}"
role="dialog"
Expand Down
1 change: 1 addition & 0 deletions src/ComposedModal/ModalBody.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
export let hasScrollingContent = false;
</script>

<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div
tabindex="{hasScrollingContent ? '0' : undefined}"
role="{hasScrollingContent ? 'region' : undefined}"
Expand Down
1 change: 1 addition & 0 deletions src/DataTable/DataTableSkeleton.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
</div>
</section>
{/if}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<table
class:bx--skeleton="{true}"
class:bx--data-table="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/FileUploader/FileUploaderButton.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
}
</script>

<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label
aria-disabled="{disabled}"
for="{id}"
Expand Down
1 change: 1 addition & 0 deletions src/FileUploader/FileUploaderDropContainer.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
}
}}"
>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label
for="{id}"
tabindex="{tabindex}"
Expand Down
1 change: 1 addition & 0 deletions src/ListBox/ListBoxField.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
$: menuId = `menu-${id}`;
</script>

<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div
bind:this="{ref}"
role="{role}"
Expand Down
1 change: 1 addition & 0 deletions src/Modal/Modal.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@
</button>
{/if}
</div>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div
id="{modalBodyId}"
class:bx--modal-content="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/NumberInput/NumberInput.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@
</script>

<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class:bx--form-item="{true}"
on:click
Expand Down
1 change: 1 addition & 0 deletions src/Search/Search.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
class:bx--search--expanded="{expanded}"
class="{searchClass}"
>
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
bind:this="{searchRef}"
class:bx--search-magnifier="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/StructuredList/StructuredListRow.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!-- svelte-ignore a11y-mouse-events-have-key-events -->
{#if label}
<!-- svelte-ignore a11y-label-has-associated-control -->
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label
tabindex="{tabindex}"
class:bx--structured-list-row="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/TextArea/TextArea.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
</script>

<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
on:click
on:mouseover
Expand Down
1 change: 1 addition & 0 deletions src/TextInput/PasswordInput.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
</script>

<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class:bx--form-item="{true}"
class:bx--text-input-wrapper="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/TextInput/TextInput.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
</script>

<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class:bx--form-item="{true}"
class:bx--text-input-wrapper="{true}"
Expand Down
1 change: 1 addition & 0 deletions src/Tile/SelectableTile.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
disabled="{disabled}"
/>
<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label
for="{id}"
tabindex="{disabled ? undefined : tabindex}"
Expand Down
1 change: 1 addition & 0 deletions src/TimePicker/TimePicker.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
</script>

<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class:bx--form-item="{true}"
on:click
Expand Down
1 change: 1 addition & 0 deletions src/Tooltip/Tooltip.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@
on:keydown="{onKeydown}"
>
<span class:bx--tooltip__caret="{true}"></span>
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
on:click|stopPropagation
on:mousedown|stopPropagation
Expand Down
1 change: 1 addition & 0 deletions src/TreeView/TreeViewNodeList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
}}"
>
<div class:bx--tree-node__label="{true}" bind:this="{refLabel}">
<!-- svelte-ignore a11y-click-events-have-key-events -->
<span
class:bx--tree-parent-node__toggle="{true}"
disabled="{disabled}"
Expand Down
1 change: 1 addition & 0 deletions src/UIShell/SideNav.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<svelte:window bind:innerWidth="{winWidth}" />

{#if !fixed}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
on:click="{() => {
dispatch('click:overlay');
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1419,10 +1419,10 @@ svelte@^3.47.0:
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029"
integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA==

svelte@^3.50.0:
version "3.50.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.50.0.tgz#d11a7a6bd1e084ec051d55104a9af8bccf54461f"
integrity sha512-zXeOUDS7+85i+RxLN+0iB6PMbGH7OhEgjETcD1fD8ZrhuhNFxYxYEHU41xuhkHIulJavcu3PKbPyuCrBxdxskQ==
svelte@^3.51.0:
version "3.51.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.51.0.tgz#a1a0afb25dc518217f353dd73ea6471c128ddf84"
integrity sha512-PBITYIrsNOuW+Dtds00gSY68raNZQn7i59Dg/fjgf6WwyawPKeBwle692coO7ILZqSO+UJe9899aDn9sMdeOHA==

terser@^5.0.0:
version "5.14.2"
Expand Down

0 comments on commit c6373dc

Please sign in to comment.