Skip to content

Commit

Permalink
ci: split into steps, remove lint
Browse files Browse the repository at this point in the history
The current lint script runs prettier on the codebase, but it does not error. Ideally, formatting should run in Git hooks and error in CI. For now, omit this step to speed up builds.
  • Loading branch information
metonym committed Aug 20, 2024
1 parent 96cfb4b commit fd41c8a
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ jobs:
path: "**/node_modules"
key: ${{ runner.os }}-modules-${{ hashFiles('**/package-lock.json') }}

- name: Install dependencies, build, test, and lint the codebase
run: |
npm install
npm run build:lib
npm run test:types
npm run lint
- name: Install dependencies
run: npm install

- name: Build the codebase
run: npm run build:lib

- name: Test types
run: npm run test:types

- name: Trigger deploy
if: github.ref == 'refs/heads/master'
Expand Down

0 comments on commit fd41c8a

Please sign in to comment.