Fix step floating point issue in NumberInput
#1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes carbon-design-system#1554: Use the built-in function of steppers then assign the value
jqlio18
changed the title
jqlio18
changed the title
step floating point issue in NumberInput
metonym
added a commit
that referenced
this pull request
Dec 8, 2022
Fast-follow to #1555. `ref.value` remains a string if not converted to a number.
|
Thank you. Fixed in v0.70.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233, fixes #486, fixes #1554
Use the built-in function of steppers then assign the value.
JS has a bug with floating point which result in a visual bug where input has many decimals.
There's 2 ways to fix this :
floatto anint(by multiplying by 10 x number of decimals) then make the equation then reconvert to a floating value.I prefer the second approach which is simpler.
Also, with this method we don't need to test the
minandmaxvalues sincestepUpandstepDownbuilt-in functions do this internally. We do need to assignvalueto the input value because Svelte won't know that the value changed.I also added a step test and updated the docs to add the step function.
For the margin I understand that because of the error Icon we can't reduce the padding, I'll update the issue.