-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release workflow improvements #1627
Conversation
- Add standard-version to automate version bumping, adding tag, and writing changelog - remove husky - add lint script - update CI pipeline to include linting for pull requests - format yet-linted files - add Enrico to contributors
lint files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up.
Tested locally and works as expected. This LGTM pending a couple of comments.
Thank you; all comments were addressed. |
This is great, especially moving the lint to CI since it caused trouble for some users when they tried contributing. Anything to make the contributing flow better and the release flow automated is a big win. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually standard-version
is deprecated and the recommended successor is https://github.com/absolute-version/commit-and-tag-version
The only changes required are to replace every standard-version
with commit-and-tag-version
( and update the dependencies )
Introducing some semi-automatic release tooling:
husky
yarn release
semi-automatic script, leveraging thestandard-version
packageHow to test:
yarn release
. This won't create a commit nor tag; those steps are manual. Note the generated changelog, package.json version bump, and documentation version bumpNext steps: once we're comfortable with these tools, we'll set up continuous delivery.