Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #168

Merged
merged 10 commits into from
Apr 19, 2020
Merged

Refactor #168

merged 10 commits into from
Apr 19, 2020

Conversation

mfeitoza
Copy link
Contributor

@metonym from official Carbon Docs:

The UI shell is made up of three components: The header, the left panel, and the right panel. All three can be used independently, but the components were designed to work together.

So I refactored to use Header and SideNav independently.
Improve the StoryBook and organize the exports.

<Header bind:isSideNavOpen>
</Header>
<SideNav bind:isOpen={isSideNavOpen}>
</SideNav>
``

And also remove <footer> from SideNav, because I didn't found nothing in Carbon Docs.

@mfeitoza mfeitoza requested a review from metonym as a code owner April 18, 2020 18:28
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the import/export conflicts in src/index.js

Copy link
Contributor Author

@mfeitoza mfeitoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@metonym metonym self-requested a review April 19, 2020 02:07
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the Storybook changes showcase the modularity of the UI Header, SideNav, and Switcher components.

Thanks again for taking the initiative with this refactor. I appreciate your focus on aligning the API with Carbon.

@metonym metonym merged commit d91dfc7 into carbon-design-system:master Apr 19, 2020
@metonym
Copy link
Collaborator

metonym commented Apr 19, 2020

Released in v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants