-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #168
Refactor #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the import/export conflicts in src/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the Storybook changes showcase the modularity of the UI Header, SideNav, and Switcher components.
Thanks again for taking the initiative with this refactor. I appreciate your focus on aligning the API with Carbon.
Released in v0.4.1 |
@metonym from official Carbon Docs:
So I refactored to use Header and SideNav independently.
Improve the StoryBook and organize the exports.