Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1684): hide helper text container in password input when not used #1685

Merged
merged 1 commit into from
Mar 11, 2023
Merged

fix(1684): hide helper text container in password input when not used #1685

merged 1 commit into from
Mar 11, 2023

Conversation

gabrielleecredera
Copy link
Contributor

@gabrielleecredera gabrielleecredera commented Mar 11, 2023 •
edited
Loading

  • hides the whole helper text container when helper text is not provided (same behaviour as in TextInput) (screenshot 1)
  • added an example in docs showing the helper text prop being used (screenshot 2)

Screenshot 2023-03-11 at 17 14 39

Screenshot 2023-03-11 at 17 14 55

fixes #1684

@theetrain theetrain self-requested a review March 11, 2023 19:03
theetrain
theetrain approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@theetrain theetrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@theetrain theetrain merged commit 42349eb into carbon-design-system:master Mar 11, 2023
@gabrielleecredera gabrielleecredera deleted the fix/1684-password-input-hide-helper-text branch March 11, 2023 19:39
@theetrain
Copy link
Collaborator

Now available in v0.73.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theetrain theetrain theetrain approved these changes

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PasswordInput leaves an empty container below the input for non-existing helper text
3 participants
@gabrielleecredera @theetrain @metonym