-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Event Forwarding To Pagination Component #185
Added Event Forwarding To Pagination Component #185
Conversation
Hi @mabentley85 – thank you for the PR. I think it would be useful to dispatch Using |
@metonym Thanks for the hint, I refactored my changes to make use of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better – this is a lot more concise.
See my comment about converting the value to a number.
@metonym Made the requested change |
Thanks again @mabentley85 for the submission! Released in v0.7.0 – changelog notes |
Added Event Forwarding to the Pagination component by adding handlers to the Next & Previous Page buttons and the Page Size and Page select fields.
These handlers will dispatch one event containing
page
andpageSize
details. This was done to prevent duplicate dispatches when thepageSize
changes, as thepage
is always set to 1 whenpageSize
is changed.Question: Is there a better way to handle select value changes than
onBlur
? UsingonChange
results in duplicate triggers since they are binded to thepage
andpageSize
variables.