Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove locales from DatePicker / flatpickr #316

Merged
merged 3 commits into from
Oct 11, 2020
Merged

remove locales from DatePicker / flatpickr #316

merged 3 commits into from
Oct 11, 2020

Conversation

weaseldotro
Copy link
Contributor

Fixes #313

@weaseldotro weaseldotro requested a review from metonym as a code owner October 8, 2020 16:08
@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/3hp22h6sv
✅ Preview: https://carbon-components-svelte-git-patch-1.carbon-svelte.vercel.app

Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the deploy preview, I'm unable to open the calendar for the "single" type DatePicker.

There are still references to l10n in the file.

Error in the DevTools console:

Screen Shot 2020-10-08 at 9 19 27 AM

@weaseldotro
Copy link
Contributor Author

Fixed, I added the missing variable.

@weaseldotro weaseldotro requested a review from metonym October 10, 2020 07:14
@vercel
Copy link

vercel bot commented Oct 11, 2020

@weaseldotro is attempting to deploy a commit to the carbon-svelte Team on Vercel.

A member of the Team first needs to authorize it.

@metonym metonym merged commit 0b6d9ee into carbon-design-system:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove locales from flatpickr (DatePicker component)
3 participants