-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(types): rewrite component TypeScript definitions #385
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3c04f12
refactor(types): rewrite type definitions to account for intrinsic at…
metonym d38e6d8
refactor: update/fix JSDoc props
metonym 75d4b4c
refactor(types): shorten ref, id JSDocs, use CarbonIcon type, export …
metonym 380a780
chore: use sveld to generate types, component docs
metonym b313fb6
docs: enhance Component API documentation
metonym 56718c6
Merge branch 'master' into rewrite-tyepscript-definitions
metonym 9987576
chore: regenerate component docs [ci skip]
metonym 1e80e42
fix(types): remove "undefined" dispatched events
metonym 26ce330
fix(tag): define JSDoc restProps type
metonym 7a1480f
fix(types): prefix icon type with "typeof"
metonym 302e82d
chore(deps): upgrade carbon-icons-svelte to 10.21
metonym eed6174
test: add TS types
metonym File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 4 additions & 10 deletions
14
src/Accordion/Accordion.Skeleton.svelte → src/Accordion/AccordionSkeleton.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export { default as Accordion } from "./Accordion.svelte"; | ||
export { default as AccordionItem } from "./AccordionItem.svelte"; | ||
export { default as AccordionSkeleton } from "./Accordion.Skeleton.svelte"; | ||
export { default as AccordionSkeleton } from "./AccordionSkeleton.svelte"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 2 additions & 8 deletions
10
src/Breadcrumb/Breadcrumb.Skeleton.svelte → src/Breadcrumb/BreadcrumbSkeleton.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export { default as Breadcrumb } from "./Breadcrumb.svelte"; | ||
export { default as BreadcrumbItem } from "./BreadcrumbItem.svelte"; | ||
export { default as BreadcrumbSkeleton } from "./Breadcrumb.Skeleton.svelte"; | ||
export { default as BreadcrumbSkeleton } from "./BreadcrumbSkeleton.svelte"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 3 additions & 6 deletions
9
src/Button/Button.Skeleton.svelte → src/Button/ButtonSkeleton.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export { default as Button } from "./Button.svelte"; | ||
export { default as ButtonSkeleton } from "./Button.Skeleton.svelte"; | ||
export { default as ButtonSkeleton } from "./ButtonSkeleton.svelte"; | ||
export { default as ButtonSet } from "./ButtonSet.svelte"; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of typing the generic icon prop with the
Add16
icondefault
type, wouldn’t it be cleaner to use thetypeof CarbonIcon
class?—it applies to the rest of icon imports.Although in this way you can’t restrict the icon size to e.g.
16
… 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion. The icon size should not matter.