Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand headers type in DataTableSkeleton, fix DataTableRow type to require "id" #415

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Nov 26, 2020

Features

This enables you to share headers between the DataTable and DataTableSkeleton components:

{#if loading}
  <DataTableSkeleton {headers} />
{:else}
  <DataTable {headers} {rows} />
{/if}

Fixes

Documentation

  • Add example "Skeleton with object headers" to DataTable docs
  • Document that the DataTable is keyed ("key" for headers, "id" for `rows)

@vercel
Copy link

vercel bot commented Nov 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/o1b75x0im
✅ Preview: https://carbon-components-svelte-git-datatable.carbon-svelte.vercel.app

@metonym metonym changed the title expands headers type in DataTableSkeleton, fix DataTableRow type to require "id" expand headers type in DataTableSkeleton, fix DataTableRow type to require "id" Nov 26, 2020
@metonym metonym merged commit 71c15db into master Nov 26, 2020
@metonym metonym deleted the datatable branch November 26, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant