Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown combobox focus #447

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Fix dropdown combobox focus #447

merged 3 commits into from
Dec 5, 2020

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Dec 5, 2020

Changes

  • fix: selecting a different combobox should focus the correct input
  • fix: selecting a different dropdown should focus the correct button
  • fix: refocus combobox input unless the related event target has a "searchbox" role (fixes ComboBox focus/cursor issue #436)

@vercel
Copy link

vercel bot commented Dec 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/lynvr6w6h
✅ Preview: https://carbon-components-svelte-git-fix-dropdown-combobox-focus.carbon-svelte.vercel.app

@metonym metonym merged commit f6877f3 into master Dec 5, 2020
@metonym metonym deleted the fix-dropdown-combobox-focus branch December 5, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComboBox focus/cursor issue
1 participant
@metonym