fix(Dropdown): update selectedId when selectedIndex changes. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/GuxSNUW2g26b1Fu5mXzTK9gqf4qV |
metonym
approved these changes
Apr 24, 2021
|
Published to NPM in version v0.32.2 |
metonym
added a commit
that referenced
this pull request
Apr 24, 2021
* feature: Add support for nested object fields in Data Table feature: Add support for nested object fields in Data Table * fix can't open dropdown with keyboard (#610) * fix(Dropdown): update selectedId when selectedIndex changes. (#611) * chore(deps-dev): patch carbon-components@10.32.1 (#613) * v0.32.2 * feature: Add support for nested object fields in Data Table feature: Add support for nested object fields in Data Table * chore: Added example for nested object values into the documentation Co-authored-by: Lyu, Wei-Da <36730922+jasonlyu123@users.noreply.github.com> Co-authored-by: David Espinosa <david.emanuel.espinosa@gmail.com> Co-authored-by: Eric Liu <ericyl.us@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
Using the dropdown we found a visual bug.
When we change the selectedIndex value from an external action like clicking a button, we can see the previously selected item active when we open the dropdown.
Here's a Minimal, Reproducible Example: https://svelte.dev/repl/159395c52c3140f996616b57d74861f4?version=3.37.0
Just wait for it to compile then:
Click the dropdown.
Click the third item.
Click the button that changes the selectedIndex.
Click the dropdown.
You will see the 2nd AND 3rd item active!
You should only see the 2nd 😅
This PR updates the internal selectedId variable when a valid selectedIndex is passed, otherwise, it sets it to undefined (its initialization value).