[Lightbox media viewer] add isolated image (media) view function #1106
Conversation
shixiedesign
changed the title
|
Deploy preview created: Built with commit: 2bcc28409392e7e09bfe52a6e5ca03d1a17594c6 |
There was a problem hiding this comment.
I see this is under media. Is this only for Image though?
I also need to think if there are any other edge cases, or roadblocks we might be neglecting throughout all of this. Have we considered accessibility on this, and how this works with a mouse and keyboard? Or transitioning between a lower breakpoint to a higher breakpoint? Will we need a new component for this? (I'm kind of thinking yes) Are there any transitional animations? Do we need a prototype (if we don't already have one) to make sure we've covered everything?
| | event | description | | ||
| |:-----------|:-------------| | ||
| | on tap | Triggers isolated media view on mobile. This view allows user to pinch, zoom and drag. | | ||
| | when zoomed out, on tap again | Returns to default view heading and copy present in the viewer | |
There was a problem hiding this comment.
Missing the reference number on these tables so we can reference them later if needed.
|
|
||
| | event | description | | ||
| |:-----------|:-------------| | ||
| | on tap | Triggers isolated media view on mobile. This view allows user to pinch, zoom and drag. | |
There was a problem hiding this comment.
It's more events than just tap here. Each of the events you called out in this line needs its own row. Like ping, drag to name a couple. We have to be very explicit here, and make sure we get all of them.
|
Gonna icebox this for now and wait for other 2 features to merge first. |
Related Ticket(s)
carbon-design-system/carbon-for-ibm-dotcom#6534
Description
Changelog
Changed