-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lit): update lit dependencies #7603
Conversation
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Deploy preview created for package Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667 |
Hey @abdonrd , thank you for the PR! The resolutions actually only seem to work on the root of the project, which is why we mainly put them in there. If you notice, the downstream test app is actually blowing up like we saw since it seems to be pulling in an older Also, I like to keep the dependencies locked (especially core dependencies) so there aren't any random surprises down the line. |
CLA Assistant Lite bot: Thank you for your contribution! Please review and sign our Contributor License Agreement before we can review and merge your pull request. The signature to be committed in order to sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Oh! That's right! yarnpkg/yarn#5039 |
Regarding this... I think it would be better to try to leave the range (with |
Update Lit dependencies in the same way as
carbon-web-components
.Also move the
resolutions
to the web-components package.