Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lit): update lit dependencies #7603

Closed
wants to merge 1 commit into from

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Nov 4, 2021

Update Lit dependencies in the same way as carbon-web-components.

Also move the resolutions to the web-components package.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7603/index.html

Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7603/index.html

Built with commit: 58995904035c646ef8d3b2d741d57a8d6b0b1667

@jeffchew
Copy link
Member

jeffchew commented Nov 5, 2021

Hey @abdonrd , thank you for the PR!

The resolutions actually only seem to work on the root of the project, which is why we mainly put them in there. If you notice, the downstream test app is actually blowing up like we saw since it seems to be pulling in an older lit-html again that doesn't play nicely with lit-element:

image

Also, I like to keep the dependencies locked (especially core dependencies) so there aren't any random surprises down the line.

@jeffchew jeffchew closed this Nov 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

CLA Assistant Lite bot: Thank you for your contribution! Please review and sign our Contributor License Agreement before we can review and merge your pull request.


The signature to be committed in order to sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@abdonrd
Copy link
Contributor Author

abdonrd commented Nov 6, 2021

Hey @abdonrd , thank you for the PR!

The resolutions actually only seem to work on the root of the project, which is why we mainly put them in there. If you notice, the downstream test app is actually blowing up like we saw since it seems to be pulling in an older lit-html again that doesn't play nicely with lit-element:

Oh! That's right! yarnpkg/yarn#5039

@abdonrd
Copy link
Contributor Author

abdonrd commented Nov 6, 2021

image

Also, I like to keep the dependencies locked (especially core dependencies) so there aren't any random surprises down the line.

Regarding this... I think it would be better to try to leave the range (with ^). Since if an application uses Carbon components + other components made in Lit... Otherwise they share the same range, there could be different versions of Lit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants