Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pictogram-item): add e2e tests #7662

Merged
merged 6 commits into from
Nov 23, 2021
Merged

test(pictogram-item): add e2e tests #7662

merged 6 commits into from
Nov 23, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Nov 15, 2021

Related Ticket(s)

#7433

Description

This PR adds Pictogram Item e2e tests for the following scenarios

a. Check pictogram item and content is loaded
b. Check the Link with icon is loaded and clickable
c. Verify Pictogram item can be customized (desktop, touch, pattern) [depends on #7661]
d. Customize theme from Carbon theme and verify gray 10, gray 90 and gray 100 theme.

@emyarod emyarod added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package test: e2e used for automated e2e testing labels Nov 15, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 15, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 15, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 15, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 15, 2021 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 16, 2021 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 16, 2021 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@emyarod emyarod marked this pull request as ready for review November 19, 2021 14:57
@emyarod emyarod requested a review from a team as a code owner November 19, 2021 14:57
@emyarod emyarod force-pushed the 7433-test/pictogram-item-e2e branch 2 times, most recently from 65535e9 to 4318f21 Compare November 19, 2021 14:58
IgnacioBecerra
IgnacioBecerra approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on the tests @emyarod!

@IgnacioBecerra IgnacioBecerra mentioned this pull request Nov 22, 2021
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 23, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7662/index.html

Built with commit: 2527cfc7b75f5fed4191890fc689f5d925f881aa

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 23, 2021
@kodiakhq kodiakhq bot merged commit 405e6a0 into carbon-design-system:master Nov 23, 2021
@emyarod emyarod deleted the 7433-test/pictogram-item-e2e branch November 23, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@photodow photodow Awaiting requested review from photodow photodow was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121 andysherman2121 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge test: e2e used for automated e2e testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emyarod @ibmdotcom-bot @IgnacioBecerra @jeffchew