Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(accordion): make chevron center-aligned #408

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

asudoh
Copy link
Collaborator

@asudoh asudoh commented May 24, 2020

We had a recent change in accordion style presumably to support multi-lines accordion title. However, the change made the text top-aligned for single line condition, and the CSS actually didn't support multi-lines accordion title. This change fixes those problems.

@netlify
Copy link

netlify bot commented May 24, 2020

Deploy preview for carbon-custom-elements ready!

Built with commit 2e6e720

https://deploy-preview-408--carbon-custom-elements.netlify.app

We had a recent change in accordion style presumably to support
multi-lines accordion title. However, the change made the text
top-aligned for single line condition, and the CSS actually didn't
support multi-lines accordion title. This change fixes those problems.
@asudoh asudoh force-pushed the accordion-alignment branch from c198009 to 96e323d Compare June 8, 2020 11:01
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, compared to existing this definitely fixes the issue.

@asudoh asudoh merged commit 6249919 into carbon-design-system:master Jul 9, 2020
@asudoh asudoh deleted the accordion-alignment branch July 9, 2020 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants