Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(lit): moved lit-element/lit-html to core dependencies #726

Merged

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Nov 1, 2021

Related Ticket(s)

Refs #723

Description

This moved the lit-element/lit-html libraries to core dependencies. peerDependencies was also cleaned up to no longer include carbon-components, as that has already been managed in dependencies for awhile now.

The scripts were also alphabetized in package.json, and added some additional entries to .gitignore.

Changelog

Changed

  • lit-element/lit-html moved to dependencies
  • trimmed down peerDependencies
  • Added .npmrc and yarn-error.log to .gitignore
  • alphabetized scripts in package.json
  • README.md updated to reflect installation changes

@jeffchew jeffchew requested a review from a team as a code owner November 1, 2021 16:18
@jeffchew jeffchew requested review from ariellalgilmore, IgnacioBecerra and DragosRistici and removed request for a team November 1, 2021 16:18
@ibmdotcom-bot
Copy link
Contributor

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 1, 2021
@kodiakhq kodiakhq bot merged commit 7f66287 into carbon-design-system:master Nov 1, 2021
@jeffchew jeffchew deleted the chore/carbon-lit-dependencies branch November 2, 2021 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants