Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(dependencies): update dev dependencies #737

Merged
merged 11 commits into from
Nov 4, 2021
Merged

chore(dependencies): update dev dependencies #737

merged 11 commits into from
Nov 4, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 3, 2021 •
edited
Loading

Update a lot of the dev dependencies.
Multiple commits to check with the CI.

Also help to fix #730

@abdonrd abdonrd requested a review from jeffchew November 3, 2021 13:00
@abdonrd abdonrd requested a review from a team as a code owner November 3, 2021 13:00
@abdonrd abdonrd requested review from IgnacioBecerra and DragosRistici and removed request for a team November 3, 2021 13:00
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/737/index.html

Built with commit: 223f2959a8641a8522962375ca82b0423a10e497

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/737/index.html

Built with commit: 223f2959a8641a8522962375ca82b0423a10e497

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 3, 2021

How can we check what happened to Angular deploy preview?
Everything else has worked!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/737/index.html

Built with commit: 223f2959a8641a8522962375ca82b0423a10e497

@jeffchew
Copy link
Member

jeffchew commented Nov 3, 2021

Some of the snapshots seem a little off now, I approved some of them which just had some minor spacing things but the accordion is missing a lower border now:

image

Also the breadcrumb is missing the dividers:

image

@jeffchew
Copy link
Member

jeffchew commented Nov 3, 2021 •
edited
Loading

How can we check what happened to Angular deploy preview? Everything else has worked!

The angular one has been finnicky lately, for some reason needs more memory to run on our CI. Going to see if restarting the build will work. But I did notice some visual diffs.

image

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 3, 2021

Wow! I don't quite understand how there can be visual differences if I have only updated dev dependencies.

@jeffchew
Copy link
Member

jeffchew commented Nov 3, 2021

Wow! I don't quite understand how there can be visual differences if I have only updated dev dependencies.

Strange indeed. I think the packages that might remotely be responsible are these but not sure...

image

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/737/index.html

Built with commit: 8b43a07b4510dff8770de5cd06e7945af3a19a29

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 3, 2021

Strange indeed. I think the packages that might remotely be responsible are these but not sure...

image

I just reverted this commit, let's see it it works...

@jeffchew
Copy link
Member

jeffchew commented Nov 3, 2021

No diffs after the update, looks like that was the culprit?

image

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 3, 2021

No diffs after the update, looks like that was the culprit?

image

No, I removed the sass updates!

@jeffchew jeffchew changed the title Update dev dependencies chore(dependencies): update dev dependencies Nov 3, 2021
jeffchew
jeffchew approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 3, 2021
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Nov 3, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 3, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@abdonrd
Merge branch 'master' into update-deps
223f295 
# Conflicts:
#	yarn.lock
@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 4, 2021

@jeffchew updated again with master!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 4, 2021
@kodiakhq kodiakhq bot merged commit 5e484d5 into master Nov 4, 2021
@kodiakhq kodiakhq bot deleted the update-deps branch November 4, 2021 14:01
@jeffchew jeffchew mentioned this pull request Nov 5, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation does not work
3 participants
@abdonrd @ibmdotcom-bot @jeffchew