Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(deps): update dependencies #810

Merged
merged 10 commits into from
Nov 17, 2021
Merged

chore(deps): update dependencies #810

merged 10 commits into from
Nov 17, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 17, 2021

Update dependencies

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 17, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/810/index.html

Built with commit: ce9f0f6ee07cdc549d284cfd6c761d632cec1480

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 17, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/810/index.html

Built with commit: ce9f0f6ee07cdc549d284cfd6c761d632cec1480

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 17, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/810/index.html

Built with commit: ce9f0f6ee07cdc549d284cfd6c761d632cec1480

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 17, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/810/index.html

Built with commit: ce9f0f6ee07cdc549d284cfd6c761d632cec1480

@abdonrd abdonrd marked this pull request as ready for review November 17, 2021 13:08
@abdonrd abdonrd requested a review from a team as a code owner November 17, 2021 13:08
@abdonrd abdonrd requested review from photodow, annawen1 and andysherman2121 and removed request for a team November 17, 2021 13:08
kennylam
kennylam reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @abdonrd! Looks like the Angular stories aren't loading correctly.

image

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

@kennylam still pending for the latest update:

Screenshot 2021-11-17 at 14 43 13

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

Now everything works except the Angular build:

https://dbg-digital-design-team-jenkins.swg-devops.com/job/Carbon%20Web%20Components%20-%20Deploy%20Preview%20-%20Angular/606/

But I have no access to see what happens.

@abdonrd abdonrd added the Ready to merge Label for the pull requests that are ready to merge label Nov 17, 2021
@abdonrd abdonrd requested a review from jeffchew November 17, 2021 16:17
@abdonrd abdonrd mentioned this pull request Nov 17, 2021
Closed
@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

All checks working now!

@kennylam
Copy link
Member

kennylam commented Nov 17, 2021 •
edited
Loading

All checks working now!

@abdonrd Sorry if I wasn't clear. It's not the deploy preview build I was referring to. None of the Angular stories are loading properly. They all throw the properties of undefined error. Perhaps this started with a previous deps update?

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

All checks working now!

@abdonrd Sorry if I wasn't clear. It's not the deploy preview build I was referring to. None of the Angular stories are loading properly. They all throw the properties of undefined error. Perhaps this started with a previous deps update?

Oh, got it!
Sorry, we have not realized that! I'll investigate.

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

@kennylam wow, it's an "old" issue... It happens even here:

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021 •
edited
Loading

@kennylam maybe with this:

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 17, 2021

@kennylam maybe we can merge this and send another PR to downgraded the storybook deps.

@abdonrd abdonrd requested a review from kennylam November 17, 2021 18:41
@kennylam
Copy link
Member

maybe we can merge this and send another PR to downgraded the storybook deps.

Sounds good!

kennylam
kennylam approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @abdonrd!

@kodiakhq kodiakhq bot merged commit f901579 into master Nov 17, 2021
@kodiakhq kodiakhq bot deleted the update-deps branch November 17, 2021 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennylam kennylam kennylam approved these changes

@photodow photodow Awaiting requested review from photodow photodow was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121 andysherman2121 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@jeffchew jeffchew Awaiting requested review from jeffchew

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdonrd @ibmdotcom-bot @kennylam