Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

docs(data-table): add variations to codesandbox example #925

Merged
merged 4 commits into from
Jan 24, 2022
Merged

docs(data-table): add variations to codesandbox example #925

merged 4 commits into from
Jan 24, 2022

Conversation

annawen1
Copy link
Member

Related Ticket(s)

bx-table sort functionality not working #916

Description

This PR is to add a couple data-table examples to the codesandbox. The data-table logic (sorting/searching/selecting) has to be handled by the application side. These examples are to help adopters hopefully quickly set up the basic functionalities.

Changelog

New

  • sortable table and sortable table with pagination examples in the data-table codesandbox.

Changed

  • add a line in the storybook doc to emphasize the logic needs to be handled by the application

@annawen1 annawen1 requested a review from a team as a code owner January 14, 2022 15:09
@annawen1 annawen1 requested review from oliviaflory and removed request for a team January 14, 2022 15:09
@annawen1 annawen1 added the documentation Improvements or additions to documentation label Jan 14, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/925/index.html

Built with commit: 5973bd1c1723477e7f4f3cf7e8f5648370601aeb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/925/index.html

Built with commit: 5973bd1c1723477e7f4f3cf7e8f5648370601aeb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/925/index.html

Built with commit: 5973bd1c1723477e7f4f3cf7e8f5648370601aeb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/925/index.html

Built with commit: 5973bd1c1723477e7f4f3cf7e8f5648370601aeb

ariellalgilmore
ariellalgilmore reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! so much easier to understand now

examples/codesandbox/basic/components/data-table/sortable-table.js Outdated Show resolved Hide resolved
src/components/data-table/data-table-story.mdx
@@ -73,7 +73,7 @@ import 'carbon-web-components/es/components/data-table/index.js';

Adding `selection-name` attribute to `<bx-table-row>`/`<bx-table-header-row>` shows the selection UI in the table row.

When user attempts to change row selection, the following events fire:
The logic of row selection needs to be handled on by the application code. When user attempts to change row selection, the following events fire:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we want to reiterate here that they can see an example of this in our codesandbox?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open up a ticket to capture the row selection codesandbox example

src/components/data-table/data-table-story.mdx Show resolved Hide resolved
ariellalgilmore
ariellalgilmore approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 24, 2022
@kodiakhq kodiakhq bot merged commit 41b5272 into carbon-design-system:main Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore