Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(tabs): basic keyboard navigation #992

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

#970

Description

This PR ensures that the Tabs and Content Switcher components are able to be work with tab navigation.

Changelog

New

  • added tab-index in the tab shadow dom

Changed

  • triggering the content switching upon pressing the enter key

Removed

  • remove unneeded inFocus property in the tab item component

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner March 21, 2022 22:33
@IgnacioBecerra IgnacioBecerra requested review from RichKummer and annawen1 and removed request for a team March 21, 2022 22:33
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 21, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 21, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 21, 2022

@ibmdotcom-bot
Copy link
Contributor

@kennylam
Copy link
Member

kennylam commented May 5, 2022

@IgnacioBecerra once #980 is complete we can also incorporate home/end interactions. See #707.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants