fix(ListBox): add title attribute to selected item (#9399)

* fix(ListBox): add title attribute to selected item * test(snapshot): update snapshots * fix(Dropdown): remove console log
carbon-design-system · Aug 24, 2021 · 097d5d9 · 097d5d9
1 parent 1b4811e
commit 097d5d9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/packages/react/src/components/ComboBox/ComboBox.js b/packages/react/src/components/ComboBox/ComboBox.js
@@ -306,6 +306,7 @@ const ComboBox = React.forwardRef((props, ref) => {
  aria-expanded={rootProps['aria-expanded']}
  aria-haspopup="listbox"
  aria-controls={inputProps['aria-controls']}
+ title={textInput?.current?.value}
  {...inputProps}
  {...rest}
  ref={mergeRefs(textInput, ref)}

diff --git a/packages/react/src/components/Dropdown/Dropdown.js b/packages/react/src/components/Dropdown/Dropdown.js
@@ -163,6 +163,7 @@ const Dropdown = React.forwardRef(function Dropdown(
  className={`${prefix}--list-box__field`}
  disabled={disabled}
  aria-disabled={disabled}
+ title={selectedItem ? itemToString(selectedItem) : label}
  {...toggleButtonProps}
  ref={mergeRefs(toggleButtonProps.ref, ref)}>
  <span className={`${prefix}--list-box__label`}>

diff --git a/packages/react/src/components/Dropdown/__snapshots__/Dropdown-test.js.snap b/packages/react/src/components/Dropdown/__snapshots__/Dropdown-test.js.snap
@@ -72,6 +72,7 @@ exports[`Dropdown should render 1`] = `
  id="downshift-0-toggle-button"
  onClick={[Function]}
  onKeyDown={[Function]}
+ title="input"
  type="button"
  >
  <span
@@ -222,6 +223,7 @@ exports[`Dropdown should render custom item components 1`] = `
  id="downshift-6-toggle-button"
  onClick={[Function]}
  onKeyDown={[Function]}
+ title="input"
  type="button"
  >
  <span
@@ -530,6 +532,7 @@ exports[`Dropdown should render with strings as items 1`] = `
  id="downshift-4-toggle-button"
  onClick={[Function]}
  onKeyDown={[Function]}
+ title="input"
  type="button"
  >
  <span