fix(ListBox): add title attribute to selected item #9399
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: dc4a9d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6124b77188f2cf0008d07400 😎 Browse the preview: https://deploy-preview-9399--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: dc4a9d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6124b771d4d6de00078bdd65 😎 Browse the preview: https://deploy-preview-9399--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: dc4a9d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6124b7710966ec0007124fb3 😎 Browse the preview: https://deploy-preview-9399--carbon-components-react.netlify.app |
|
Is it possible for non-mouse users to see the full list item label somehow or is it also truncated in the listbox? |
|
@dakahn doesn't seem like it, this just matches the list menu experience (which also doesn't have a way for a non-mouse user to view the truncated text). A longer-term solution should be created in a separate issue and would need to be implemented consistently throughout the components |
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
|
@tw15egan i'll bang out a ticket |
andreancardona
added
status: ready to merge 🎉
and removed
status: ready to merge 🎉
labels
|
@tw15egan is this ready to be merged? :) |
tw15egan
force-pushed
the
title-text-listbox
branch
from
c65bd0b
to
dc4a9d3
Compare
Closes #9397
Adds title attribute so that long text can be revealed when it is the currently selected item
Changelog
New
titleattribute to the selected itemspan/inputTesting / Reviewing
Pick the text the longest text/text that is truncated. When the Dropdown / Combobox is closed, ensure the text is shown on hover