Skip to content

Commit e4507e1

Browse files
abbeyhrtasudoh
authored andcommitted
fix(checkbox-skeleton): apply skeleton class to checkbox (#4923)
1 parent ef0752e commit e4507e1

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

packages/components/src/components/checkbox/_checkbox.scss

+11
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,17 @@
185185
.#{$prefix}--checkbox-label[data-contained-checkbox-state='mixed'][data-contained-checkbox-disabled='true']::before {
186186
background-color: $disabled-02;
187187
}
188+
189+
//-----------------------------------------------
190+
// Skeleton
191+
//-----------------------------------------------
192+
193+
.#{$prefix}--checkbox-label-text.#{$prefix}--skeleton {
194+
@include skeleton;
195+
width: rem(100px);
196+
height: $spacing-05;
197+
margin: auto 0;
198+
}
188199
}
189200

190201
@include exports('checkbox') {

packages/react/src/components/Checkbox/Checkbox-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ describe('CheckboxSkeleton', () => {
163163
});
164164

165165
it('has the expected classes', () => {
166-
expect(label.hasClass(`${prefix}--checkbox-label`)).toEqual(true);
166+
expect(label.hasClass(`${prefix}--checkbox-label-text`)).toEqual(true);
167167
expect(label.hasClass(`${prefix}--skeleton`)).toEqual(true);
168168
});
169169
});

packages/react/src/components/Checkbox/Checkbox.Skeleton.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ const CheckboxSkeleton = ({ className, ...rest }) => (
1717
className={cx(
1818
`${prefix}--form-item`,
1919
`${prefix}--checkbox-wrapper`,
20+
`${prefix}--checkbox-label`,
2021
className
2122
)}
2223
{...rest}>
23-
<span className={`${prefix}--checkbox-label ${prefix}--skeleton`} />
24+
<span className={`${prefix}--checkbox-label-text ${prefix}--skeleton`} />
2425
</div>
2526
);
2627

0 commit comments

Comments
 (0)