fix(checkbox-skeleton): apply skeleton class to checkbox #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbeyhrt
requested review from
a team
and removed request for
asudoh and
aledavila
|
Deploy preview for the-carbon-components ready! Built with commit 62e84d4 https://deploy-preview-4923--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 62e84d4 |
|
Deploy preview for carbon-components-react ready! Built with commit 62e84d4 https://deploy-preview-4923--carbon-components-react.netlify.com |
ghost
requested review from
joshblack and
vpicone
and removed request for
a team
jeanservaas
reviewed
Jan 6, 2020
|
@jeanservaas I believe it is! At least to the best that I can tell, it looks like the same distance. |
joshblack
approved these changes
Jan 7, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
status: visual review 🔍
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4901
This PR adjusts the CheckBoxSkeleton component and adds the appropriate styles so that the skeleton state is visibly applied.
What the CheckBoxSkeleton looked like before:
What it looks like now:
Changelog
New
Changed
Testing / Reviewing
Designers: Make sure that this is what we want the checkbox skeleton state to look like!