Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: request to add "Select all" to TableBatchActions component #12595

Closed
1 task done
matthewgallo opened this issue Nov 10, 2022 · 8 comments · Fixed by #14476
Closed
1 task done

[Feature Request]: request to add "Select all" to TableBatchActions component #12595

matthewgallo opened this issue Nov 10, 2022 · 8 comments · Fixed by #14476
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: data-table package: @carbon/react @carbon/react package: react carbon-components-react proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone

Comments

@matthewgallo
Copy link
Member

The problem

Hello! The DSAG group/Carbon for IBM Products team has data table designs that call for including a "Select all" button next to the totalSelected prop (x items selects) text within the TableBatchActions component. We are hoping that this could potentially be an optionally included piece to the TableBatchActions component.

Here is some design guidance provided by @marion-bruells:

When dealing with large amount of data, users sometimes require to select items across all pages, not only the current one. We added this button as extension, so when the user clicks on Select all, all items in this table are selected (across all pages). When the user performs an action now, all pages are affected. The default is that only items on the current page are selected. To exit or escape the batch action mode, the user can cancel out or deselect the items with the checkbox in the column header. See guidance here. You probably know a similar behaviour from gmail and other tools.

The solution

Being able to optionally include a select all button to render next to the totalSelected text inside of the TableBatchActions component
Screenshot 2022-11-10 at 10 49 18 AM

Examples

Here is another example, from gmail.
Screen Shot 2022-11-10 at 10 16 00 AM

Application/PAL

Carbon for IBM Products

Business priority

Medium Priority = upcoming release but is not pressing

Available extra resources

https://pages.github.ibm.com/cdai-design/pal/components/data-table/batchactions/usage

Code of Conduct

@matthewgallo
Copy link
Member Author

Our team was hoping to also have this included as part of v10 and v11, if possible.

@sstrubberg sstrubberg added version: 10 Issues pertaining to Carbon v10 version: 11 Issues pertaining to Carbon v11 component: data-table proposal: open This request has gone through triaging. We're determining whether we take this on or not. adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG package: react carbon-components-react package: @carbon/react @carbon/react labels Nov 17, 2022
@sstrubberg
Copy link
Member

@matthewgallo you wouldn't happen to be available to contribute.. would ya? ;)

@matthewgallo
Copy link
Member Author

matthewgallo commented Dec 8, 2022

Our team would be happy to contribute but it will likely have to be in the new year. Thanks @sstrubberg!

@sstrubberg sstrubberg added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Dec 15, 2022
@sstrubberg
Copy link
Member

Our team would be happy to contribute but it will likely have to be in the new year. Thanks @sstrubberg!

Excellent! Let's get together and talk Acceptance Criteria after the holidays.

@sstrubberg
Copy link
Member

From DataTable backlog grooming call:

Design needs to weigh in on this pattern. It needs specs. Core Carbon should own, but anyone could contribute it.

@sstrubberg sstrubberg removed version: 10 Issues pertaining to Carbon v10 needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Mar 15, 2023
@sstrubberg sstrubberg added this to the 2023 Q2 milestone Mar 15, 2023
@tay1orjones
Copy link
Member

@matthewgallo Just to clarify - is this request to just better support rendering the button, or are you asking for the actual Select All functionality to be built into DataTable?

@tay1orjones tay1orjones modified the milestones: 2023 Q2, 2023 Q3 Jul 10, 2023
@elycheea
Copy link
Contributor

On a call with @matthewgallo right now — I think we just need to support the rendering. We already have the logic for select all on our side. @matthewgallo may have some time to contribute this soon though. 🤞

@matthewgallo
Copy link
Member Author

matthewgallo commented Aug 17, 2023

Would love to contribute this as our designs still require this approach, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: data-table package: @carbon/react @carbon/react package: react carbon-components-react proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants