-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DataTable): add batch actions select all button addition #14476
Merged
guidari
merged 4 commits into
carbon-design-system:main
from
matthewgallo:12595-batch-acitons-select-all-button-addition
Aug 24, 2023
Merged
feat(DataTable): add batch actions select all button addition #14476
guidari
merged 4 commits into
carbon-design-system:main
from
matthewgallo:12595-batch-acitons-select-all-button-addition
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Aug 23, 2023
guidari
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 🚀
Merged
via the queue into
carbon-design-system:main
with commit Aug 24, 2023
db61c68
14 checks passed
matthewgallo
deleted the
12595-batch-acitons-select-all-button-addition
branch
August 24, 2023 15:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12595
This PR adds a
Select all
button to the TableBatchActions component ifonSelectAll
is passed to the component. The actual select all logic will be handled by the consumer as discussed in #12595. The main purpose of this addition is so that we can implement the following in the batch action toolbar in Carbon for IBM ProductsDatagrid
:Changelog
New
onSelectAll
andtotalCount
properties toTableBatchActions
onSelectAll
is called as expectedChanged
small
tosm
in the batch action stories.Testing / Reviewing
I have added these two new props to one of the DataTable batch action stories to view as an example and added an additional test to validate that
onSelectAll
is called appropriately.