Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data table should have a <caption> element #1578

Closed
dakahn opened this issue Dec 21, 2018 · 4 comments
Closed

Data table should have a <caption> element #1578

dakahn opened this issue Dec 21, 2018 · 4 comments
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities type: a11y ♿

Comments

@dakahn
Copy link
Contributor

dakahn commented Dec 21, 2018 •
edited
Loading

Environment

Chrome 70
macOS Mojave

Problem/Violation

Screen reader users would benefit from a <caption> element on the data table describing the tables contents.

Reference

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/caption
@dakahn dakahn added type: a11y ♿ good first issue 👋 Used by GitHub to elevate contribution opportunities project: components labels Dec 21, 2018
@dakahn dakahn mentioned this issue Dec 21, 2018
Closed
1 task
@joshblack
Copy link
Contributor

What kind of conventions are typical for this?

@dakahn
Copy link
Contributor Author

dakahn commented Jan 7, 2019

A summary of the information in the table. There's a write up in the reference link, but something like this:

screen shot 2019-01-07 at 12 01 23 pm

@joshblack
Copy link
Contributor

@dakahn wouldn't this be up to teams to include? DataTable is a state container so it just accepts a render prop.

@dakahn
Copy link
Contributor Author

dakahn commented Mar 18, 2019

Closing!

@dakahn dakahn closed this as completed Mar 18, 2019
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@emyarod @alisonjoseph
feat(InlineCheckbox): allow optional tooltip (carbon-design-system#1578)
c1a6b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshblack @dakahn