AVT 1 - React or the Header Base w/Navigation, Actions & SideNav UI Shell has DAP violations

[snidersd]

Environment

macOS Mojave version 10.14.5
Chrome Version 75.0.3770.100 (Official Build) (64-bit)
Carbon v10 - React
DAP - July 2019 Ruleset

Detailed Description

Run DAP on the Header Base w/Navigation, Actions & SideNav UI Shell. The following 7 violations:

violations are identified (see screenshots below):

Note:
Add a role to the parent of the menuitems. Use role="menu" or "menubar" or "group" to fix the issue. DAP only reports this issue if the page size reduced and the links do not display across the top of the page.

[abbeyhrt]

@snidersd looking into this, it seems the color contrast violation is coming from the SkipToContent component when it's not visible, DAP mistakenly sensing it there with our regular a tag color. If you run DAP with the SkipToContent visible, no violation is present:

and the "Each page should have no more than one main section..." violation is just coming from our storybook environment, not from the UIShell itself. If we address the "An element with WAI-ARIA role must be contained within a valid element" violations, could we close this issue?

[snidersd]

@abbeyhrt @mattrosno I reported the color contrast violation on the Skip to Main to the Accessibility Web Engine Github repo # 234. If the violation, "An element with WAI-ARIA role must be contained within a valid element" is addressed the issue should be closed. Thx.

[asudoh]

If the violation, "An element with WAI-ARIA role must be contained within a valid element" is addressed the issue should be closed.

Thank you for clarifying @snidersd - I don't see such violation in latest code. Closing.