Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AccordionSkeleton]: margins around arrow icon are off when align="end" #4962

Closed
jendowns opened this issue Jan 7, 2020 · 1 comment · Fixed by #4963
Closed

[AccordionSkeleton]: margins around arrow icon are off when align="end" #4962

jendowns opened this issue Jan 7, 2020 · 1 comment · Fixed by #4963
Labels
component: accordion package: components carbon-components role: dev 🤖 type: bug 🐛

Comments

@jendowns
Copy link
Contributor

jendowns commented Jan 7, 2020

Detailed description

When align="end" for the AccordionSkeleton, the margins appear off (i.e., flush with no margins / colliding) around the arrow icon:
Screen Shot 2020-01-07 at 11 20 54 AM

You can see the margin issue in the React storybook environment here: http://react.carbondesignsystem.com/?path=/story/accordion--skeleton

To me it seems like a good solution would be the mirror the same spacing for the align="start" variation.
@jendowns
Copy link
Contributor Author

jendowns commented Jan 7, 2020 •
edited
Loading

I can open a PR to propose a fix shortly 👍

UPDATE: PR is here -- #4963

@jendowns jendowns mentioned this issue Jan 7, 2020
Merged
@jendowns jendowns changed the title [AccordionSkeleton]: margins around arrow icon are off [AccordionSkeleton]: margins around arrow icon are off when align="end" Jan 7, 2020
@joshblack joshblack added component: accordion package: react carbon-components-react role: dev 🤖 type: bug 🐛 package: components carbon-components and removed package: react carbon-components-react labels Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: accordion package: components carbon-components role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(accordion-skeleton): add margin between icon & text when align=end
2 participants
@joshblack @jendowns