Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accordion-skeleton): add margin between icon & text when align=end #4963

Merged
merged 8 commits into from
Jan 9, 2020
Merged

fix(accordion-skeleton): add margin between icon & text when align=end #4963

merged 8 commits into from
Jan 9, 2020

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Jan 7, 2020 •
edited
Loading

Closes #4962

Changelog

Changed

  • add left margin, to give more spacing between icon & text when align prop is set to "end"

@jendowns jendowns requested a review from a team as a code owner January 7, 2020 17:28
@ghost ghost requested review from aledavila and joshblack January 7, 2020 17:28
@jendowns jendowns mentioned this pull request Jan 7, 2020
Closed
@jendowns jendowns changed the title fix(accordion-skeleton): add margin b/t icon & text when align=end fix(accordion-skeleton): add margin between icon & text when align=end Jan 7, 2020
@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for the-carbon-components ready!

Built with commit e6a65c5

https://deploy-preview-4963--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for carbon-elements ready!

Built with commit e6a65c5

https://deploy-preview-4963--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for carbon-components-react ready!

Built with commit e6a65c5

https://deploy-preview-4963--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit 44c9b6f

https://app.netlify.com/sites/carbon-elements/deploys/5e167270b3e5f1000a45ec01

@netlify
Copy link

netlify bot commented Jan 7, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 44c9b6f

https://deploy-preview-4963--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 44c9b6f

https://app.netlify.com/sites/carbon-components-react/deploys/5e167270e65f510008fab77b

@joshblack joshblack requested a review from a team January 7, 2020 22:44
@ghost ghost requested review from laurenmrice and removed request for a team January 7, 2020 22:44
laurenmrice
laurenmrice requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do 16px instead of 8px after the skeleton header line and before the chevron to be consistent with the other spacings?

Screen Shot 2020-01-08 at 11 25 57 AM

@jendowns
Copy link
Contributor Author

jendowns commented Jan 8, 2020

Thanks @laurenmrice! I just updated that left margin from spacing-03 to spacing-05

@laurenmrice
Copy link
Member

laurenmrice commented Jan 8, 2020 •
edited
Loading

@jendowns thanks jen! the react deploy failed but once they are up again i will review

@jendowns
Copy link
Contributor Author

jendowns commented Jan 8, 2020

@laurenmrice it looks like the React deployment is finally working, so it should be good to look at now 👀

laurenmrice
laurenmrice approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you !

@asudoh asudoh merged commit 078da53 into carbon-design-system:master Jan 9, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
@jendowns @joshblack
fix(accordion-skeleton): add margin between icon & text when align=end (
ff08e44 
carbon-design-system#4963)
@joshblack joshblack mentioned this pull request Jan 13, 2020
Closed
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 14, 2020
@jendowns @joshblack
fix(accordion-skeleton): add margin between icon & text when align=end (
1ce3789 
carbon-design-system#4963)
@joshblack joshblack mentioned this pull request Jan 14, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@aledavila aledavila aledavila approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AccordionSkeleton]: margins around arrow icon are off when align="end"
6 participants
@jendowns @laurenmrice @joshblack @aledavila @abbeyhrt @asudoh