Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Table Expand Row needs the ability to add text (hidden or visual) to table header #5028

Closed
sandraclarkdev opened this issue Jan 14, 2020 · 0 comments · Fixed by #5060
Closed

Data Table Expand Row needs the ability to add text (hidden or visual) to table header #5028

sandraclarkdev opened this issue Jan 14, 2020 · 0 comments · Fixed by #5060
Labels
type: a11y ♿

Comments

@sandraclarkdev
Copy link

Environment

Operating system
Windows

Browser
Chrome/FireFox/IE

Automated testing tool and ruleset

Assistive technology used to verify
WAVE/Jaws

Detailed description

When using there should be a way to add either a visual or hidden text for screen readers "Expanded" to allow that row to have a non-empty header.

Violates WCAG 2.0/2.1 1.3.1 Info and Relationships (Level A)

What version of the Carbon Design System are you using?
10.3.0 / React 7.3.0

What did you expect to happen?
That the <TableExpandHeader would give me the ability to add props for "setHeaderText("string") and showHeaderText(true/false). If setHeaderText is not empty, it would either visually show the text on the column header or if false, arrange that it is positioned off-left and readable by screen readers.

What happened instead?

What WCAG 2.1 checkpoint does the issue violate?

Steps to reproduce the issue

  1. Set up a Data Table with a TableExpandedRow
  2. Verify page in WAVE
  3. Note that WAVE fails for Empty table header
  4. etc.

Please create a reduced test case in CodeSandbox
https://2bvnv.csb.app/

Additional information

  • Screenshots or code
    image

  • Notes
asudoh added a commit to asudoh/carbon-components that referenced this issue Jan 16, 2020
@asudoh
feat(DataTable): allow additional contents to expand cells
186a8ad 
This change adds `children` prop support to `<TableExpandHeader>`. This
provides applications with more control so application can better
describe the expand cell.

Fixes carbon-design-system#5028.
@asudoh asudoh mentioned this issue Jan 16, 2020
Merged
asudoh added a commit that referenced this issue Jan 25, 2020
@asudoh
feat(DataTable): allow additional contents to expand cells (#5060)
f3422c4 
This change adds `children` prop support to `<TableExpandHeader>`. This
provides applications with more control so application can better
describe the expand cell.

Fixes #5028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(DataTable): allow additional contents to expand cells asudoh/carbon-components
1 participant
@sandraclarkdev