Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSnippet focus indicator looks broken #5283

Closed
2 tasks done
snrubnomis opened this issue Feb 6, 2020 · 1 comment
Closed
2 tasks done

CodeSnippet focus indicator looks broken #5283

snrubnomis opened this issue Feb 6, 2020 · 1 comment

Comments

@snrubnomis
Copy link

snrubnomis commented Feb 6, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.
The CodeSnippet focus indicator has some issues:

  • The outline doesn't match other focus indicators in Carbon
  • When the content is not long enough to cause horizontal scrolling, the focus indicator goes below the field
  • The focus indicator cutting through the field rather than going to the left and right edges makes it look broken

image

image

Is this issue related to a specific component?

CodeSnippet

What did you expect to happen? What happened instead? What would you like to
see changed?

A focus indicator that matches other Carbon components in style and that neatly surrounds the component rather than cutting through it or hanging down below.

What browser are you working in?

Chrome, Firefox, Safari, Edge, IE11

What version of the Carbon Design System are you using?

carbon-components: 10.9.3
carbon-components-react: 7.9.3

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

  1. Use a single line code snippet
  2. Click to focus
  3. See ugly focus indicator

Please create a reduced test case in CodeSandbox

You can see most of the issues in the storybook. You would need to shorten the content to see it without the scroll bar.

Additional information

  • Screenshots or code
  • Notes
@laurenmrice
Copy link
Member

laurenmrice commented Feb 6, 2020

This should be fixed with this merged pr in the next release: #5233

@tw15egan tw15egan closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants