fix(code-snippet): use Carbon focus outline and reposition scroll bar #5233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 5827f26 https://deploy-preview-5233--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 80f4743 https://app.netlify.com/sites/carbon-components-react/deploys/5e38b83345480100084fe307 |
|
Deploy preview for carbon-elements ready! Built with commit 80f4743 |
tw15egan
approved these changes
Jan 31, 2020
packages/components/src/components/code-snippet/_code-snippet.scss
Outdated
Show resolved
Hide resolved
emyarod
force-pushed
the
2304-focus-outline-single-line-code-snippet
branch
from
13fa6bb
to
5827f26
Compare
laurenmrice
approved these changes
Feb 3, 2020
|
Got a green light from @emyarod to mark this as "status: ready to merge". |
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2304
Closes #5219
This PR adds Carbon focus styles to the single line code snippet instead of using the browser default. The component is also repositioned to account for the scroll bar across different platforms
Testing / Reviewing
Ensure that the focus style is visually correct, and that scroll bars look correct on all platforms (including using various scroll bar preferences in macOS System Preferences > General)