Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput inline style #5915

Closed
zoyun opened this issue Apr 23, 2020 · 5 comments · Fixed by #6252
Closed

TextInput inline style #5915

zoyun opened this issue Apr 23, 2020 · 5 comments · Fixed by #6252
Labels
component: text-input type: enhancement 💡

Comments

@zoyun
Copy link

zoyun commented Apr 23, 2020

Summary

label text and input should be inline. It looks as Select component inline style.

Justification

Label text and input should be inline by UX design, and it's the usual style

Desired UX and success metrics

It looks as Select component inline style.
@tw15egan
Copy link
Collaborator

@carbon-design-system/design do we have any plans to implement an inline text input?

@aagonzales
Copy link
Member

aagonzales commented Apr 23, 2020 •
edited
Loading

@zoyun do you mean inline as in not having a visual background to the input or aligning the label and input horizontally?

@zoyun
Copy link
Author

zoyun commented Apr 24, 2020

@aagonzales I mean aligning the label and input horizontally, thanks.

@aagonzales
Copy link
Member

We don't have any current plans to implement this style but we're not saying its not allowed just that its not currently on our roadmap. We can add this to the back log.

@zoyun
Copy link
Author

zoyun commented Apr 28, 2020

@aagonzales Thanks for your reply. I think I can try to contribute to this.

@zoyun zoyun mentioned this issue Apr 29, 2020
Closed
@lucasmccomb lucasmccomb mentioned this issue Jun 10, 2020
Merged
joshblack pushed a commit that referenced this issue Jul 9, 2020
@lucasmccomb @tw15egan @laurenmrice
feat(text-input): add inline option for TextInput (#5915) (#6252)
ac08e62 
* feat(text-input): add inline option for TextInput (#5915)

Changes TextInput react component to allow for inline variant
and adds required styles. Updates TextInput Storybook page
to include inline variant in Knobs tab.

* chore(storybook): content fix

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: text-input type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(text-input): add inline option for TextInput (#5915)
feat(text-input): support inline style
4 participants
@zoyun @emyarod @aagonzales @tw15egan