feat: add read only time picker #12420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aagonzales
requested changes
Nov 2, 2022
lee-chase
requested review from
aagonzales
and removed request for
tay1orjones and
tw15egan
|
@aagonzales @quarryboy adjusted the cusror. One thing to note is that this leaves use with the odd situation that it is possible to select and copy the time, but not AM/PM or timezone. |
aagonzales
approved these changes
Nov 11, 2022
alisonjoseph
approved these changes
Nov 14, 2022
tw15egan
force-pushed
the
readonlyTimePicker
branch
from
f7feb61
to
eeb62af
Compare
tw15egan
force-pushed
the
readonlyTimePicker
branch
from
eeb62af
to
96fbafb
Compare
tw15egan
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
@lee-chase cleaned up the merge conflicts, everything else looks great to me 👍🏻 ✅
tw15egan
added
status: ready to merge 🎉
and removed
status: visual review 🔍
status: merge conflict 🚫
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2177
Closes #12409
Adds the read-only feature to the TimePicker component.
Changelog
Added
Adds readOnly property to TimePicker and functionality
Adds test for read-only TimePicker
Adds styling for read-only TimePicker.
Fixes disabled dropdowns. Could move this to a separate PR but relies upon work required for this too.
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.