Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time-picker): add storybook controls #12472

Merged
merged 7 commits into from
Nov 12, 2022

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Nov 3, 2022

Closes #12356

Make sure stories work as intended.
Make sure controls work as intended and only showing in playground

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 340ab93
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636f2ce358966f0007cfe4bc
😎 Deploy Preview https://deploy-preview-12472--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 340ab93
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636f2ce35401f60008087a6b
😎 Deploy Preview https://deploy-preview-12472--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aledavila aledavila marked this pull request as ready for review November 3, 2022 05:31
@aledavila aledavila requested a review from a team as a code owner November 3, 2022 05:31
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but otherwise looks great 👍🏻

@kodiakhq kodiakhq bot merged commit b23ebd9 into carbon-design-system:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: update controls for TimePicker, remove /next and export toggle
3 participants