Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tile): 12679 - Replace Enzyme tests with RTL #12701

Merged
merged 7 commits into from
Dec 1, 2022

Conversation

cknabe
Copy link
Contributor

@cknabe cknabe commented Nov 18, 2022

Closes #12679

  • I began with Abbey's script, which is why there are some overall structural changes.

image

@cknabe cknabe requested a review from a team as a code owner November 18, 2022 22:47
@cknabe
Copy link
Contributor Author

cknabe commented Nov 18, 2022

There are several TODOs at the bottom of the original test file:

  // Todo: Testing for a disabled ClickableTile
  // Todo: Testing for ExpandableTile
  // Todo: Testing for RadioTile

Should these be moved into a tracked issue?

@tay1orjones
Copy link
Member

@cknabe Yes, good catch - thanks! I opened #12750 for it.

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 12b051a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6388af34284b5a0008812e4d
😎 Deploy Preview https://deploy-preview-12701--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 12b051a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6388af34084df5000817db64
😎 Deploy Preview https://deploy-preview-12701--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 115e1f9 into carbon-design-system:main Dec 1, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.18.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in Tile/Tile-test.js
4 participants