fix(DataTable): mock Canvas and remove dependency #13972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alisonjoseph
approved these changes
Jun 12, 2023
tay1orjones
approved these changes
Jun 12, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
|
Can confirm this seems to fix the issue I was having (#13964). From this branch, I'm now able to get the stack up and running using: # from root
yarn install && yarn build
cd packages/react
yarn storybook |
francinelucca
added a commit
to francinelucca/carbon
that referenced
this pull request
Jun 12, 2023
…em#13972) * fix(DataTable): mock Canvas and remove dependency * fix: trigger change --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13964
Removes
canvasdependency and mocks the function for testing insteadChangelog
Changed
HTMLCanvasElement.getContextinDatatabletestsRemoved
canvasdevDependencyTesting / Reviewing
All tests should pass and no errors should show up when installing or running tests locally. Should also have no visual/behavioral regressions