Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip & DefinitionTooltip changed storybook and functionality #15887

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Mar 5, 2024

Closes #12921

There is a couple changes made in storybook and also in the functionality. Now the Tooltip and DefinitionTooltip have similar behaviour, except for the onClick on DefinitionTooltip.

Changelog

  • Changed defaultOpen to false on Tolltip Playground
  • Add onFocus to DefinitionTooltip

Testing / Reviewing

  • Test the Tooltip and DefinitionTolltip

@guidari guidari marked this pull request as ready for review March 5, 2024 13:54
@guidari guidari requested a review from a team as a code owner March 5, 2024 13:54
@guidari guidari requested review from alisonjoseph and tw15egan March 5, 2024 13:54
@guidari guidari requested review from a team and aagonzales and removed request for a team March 5, 2024 13:54
@guidari
Copy link
Contributor Author

guidari commented Mar 5, 2024

Hey @aagonzales .
When you have the chance, can I get a design consultation in this issue. They are simple changes, but just to make sure there is nothing missing.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4ee5834
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e72371fb98ab00087afe76
😎 Deploy Preview https://deploy-preview-15887--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8ca4780
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e766a12c4b7a000802a027
😎 Deploy Preview https://deploy-preview-15887--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@guidari guidari requested a review from a team as a code owner March 5, 2024 18:36
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@guidari guidari added this pull request to the merge queue Mar 7, 2024
Merged via the queue into carbon-design-system:main with commit f84d546 Mar 7, 2024
37 checks passed
@guidari guidari deleted the 12921-tooltip branch March 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Tooltip examples and behaviour need to be updated
4 participants