fix(16337): close DatePicker calendar on away click when inside Modal or ComposedModal #16758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2nikhiltom
commented
Jun 12, 2024
There was a problem hiding this comment.
The changes in fixEventsPlugin.js will be made available from #16742
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -45,6 +47,7 @@ export const Default = () => { | |||
| modalHeading="Add a custom domain" | |||
| modalLabel="Account resources" | |||
| primaryButtonText="Add" | |||
| //isNested | |||
There was a problem hiding this comment.
I think this comment can be removed!!
| @@ -109,9 +109,10 @@ export default (config) => (fp) => { | |||
| if (inputTo.value) { | |||
| fp.setDate( | |||
| [inputFrom.value, inputTo.value], | |||
| true, | |||
| false, | |||
There was a problem hiding this comment.
Does previously sending the second value as true , was forcefully firing onChange event ?
There was a problem hiding this comment.
This looks like a great hack @2nikhiltom . Great work I must say !!
|
fixed via #17072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16337
The root bug with DatePicker was : When using the datepicker with a range selection, the end date calendar does not close when the user clicks away, causing it to always stay open (Issue -> PR)
Fix for #16337 is dependent on PR
Also this issue was happing because
evt.stopPropagation()was added onMousedownevent to add support for Nest modalTo fix #16337 : I thought to keep this action behind a prop
isNested, in modal.tsx.evt.stopPropagation()only when theisNestedprop is present.I am looking for reviews and suggestions on this.
If
isNestedprop works as a fix , I will be implementing this is inComposedModalas wellTesting / Reviewing
Verify the functionlity when
isNestedis passedisNestedas a prop inModal