Added decorator to DatepickerInput component
#18064
Open
+115
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
changed the title
decorator to DatepickerInput component
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18064 +/- ##
==========================================
+ Coverage 82.10% 82.16% +0.06%
==========================================
Files 404 404
Lines 14107 14127 +20
Branches 4426 4414 -12
==========================================
+ Hits 11582 11607 +25
+ Misses 2363 2358 -5
Partials 162 162 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
packages/react/src/components/DatePickerInput/DatePickerInput.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
riddhybansal
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17991
Added decorator to
DatepickerChangelog
New
decoratorprop added toDatepickerInputcomponentChanged
slugpropblock-sizeto the style to fix the alignment (this fix can be used on components that are inside an input)Testing / Reviewing
Make sure the
Datepickerstill work as expected and the one withdecoratoralso works fineDelete
DatepickerInputwithTooltip