Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-indicator): new component #18191

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #17539

worked on with @preetibansalui and @2nikhiltom! 🎉

New Icon indicator component

Changelog

New

  • new Icon indicator component, stories, tests, readme for react and web components
  • new icon indicator styles
  • new status tokens in themes packags

Changes

  • update data-table dynamic story to include the icon-indicator component in the status column

Testing / Reviewing

confirm icon indicators look good in react and web component storybooks
confirm tests and coverage are passing

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 4fc15b6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674f6afed21dd9000896ddf6
😎 Deploy Preview https://deploy-preview-18191--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4fc15b6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674f6afe3cd0780008d93f7b
😎 Deploy Preview https://deploy-preview-18191--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4fc15b6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674f6afe234e6400086b65c7
😎 Deploy Preview https://deploy-preview-18191--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (f2ba3fd) to head (4fc15b6).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...kages/react/src/components/IconIndicator/index.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18191      +/-   ##
==========================================
+ Coverage   83.22%   83.74%   +0.51%     
==========================================
  Files         404      406       +2     
  Lines       14338    14365      +27     
  Branches     4645     4648       +3     
==========================================
+ Hits        11933    12030      +97     
+ Misses       2243     2173      -70     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Status indicators] Implement Icon indicator
1 participant