-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): ai label revert error warning divider styles #18405
base: main
Are you sure you want to change the base?
fix(form): ai label revert error warning divider styles #18405
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18405 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 408 408
Lines 14435 14435
Branches 4640 4690 +50
=======================================
Hits 12150 12150
Misses 2121 2121
Partials 164 164 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if any of this should be put in a separate issue. I already am making a separate issue for other things in general, but can add some of these as well if its not related.
Default style
Invalid and Warning: The following components need to have a divider between the invalid and AI label icons. The select component is currently doing it right:
- Dropdown
- Multiselect
- Filterable multiselect
- Combobox

Fluid style
Invalid: When there is an invalid state present, the stacking of these inputs should not create a double border (2px stroke) between the inputs and it should still be 1px. This is appearing with the stacking of date picker, number input, text input, and text area.

Invalid: I also see that the invalid border is not flush or straight on the left and right sides for all of the components that are stacking, and it’s creating jagged edges. I am thinking there might be a shift happening once the invalid prop is set to true.

Invalid and Warning: The AI gradient on these inputs in the invalid and warning state is supposed to come from the bottom of the container where the error/warning message is, like this image below. Even though this is related to the invalid and warning states, I would assume this change would actually need to be made in the individual experimental components first and not in form?

Invalid and Warning: There are some padding problems with either the invalid/warning icons or maybe it’s actually the chevron icon in the following components. There should be 16px to the right of the invalid/warning/chevron icons to create better vertical alignment:
- Text area
- Dropdown
- Multiselect
- Combobox
- Select
Invalid and Warning: For Combobox, if you choose an option from the menu, the top field has some bugs with the close icon and a divider overlapping with the AI label.
Closes #18116
Fix styling bugs present in number input, fluid number input, text area and fluid select when error/warning states are combined with the AiLabel and AiLabel revert.
Changelog
Testing / Reviewing
Check number input, fluid number input, text area and fluid select components:
Go to the Form > With AI Label story
Check invalid state
Check warning state
Check revertActive
Check revertActive with invalid
Check revertActive with warning