Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(themes): fix link in themes README.md #18406

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeremyfrank
Copy link
Member

Fixes a broken link in the readme

@jeremyfrank jeremyfrank requested a review from a team as a code owner January 22, 2025 19:29
Copy link
Contributor

github-actions bot commented Jan 22, 2025

Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
✅ (Gururajj77)[https://github.com/Gururajj77]
@jeremyfrank
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0b078a0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67987d2c3b2f410008f4a507
😎 Deploy Preview https://deploy-preview-18406--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0b078a0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67987d2c458f970008ea3f57
😎 Deploy Preview https://deploy-preview-18406--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b078a0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67987d2cb5a7530008e27873
😎 Deploy Preview https://deploy-preview-18406--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (9ec6285) to head (0b078a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18406   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14449    14449           
  Branches     4696     4700    +4     
=======================================
  Hits        12161    12161           
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching that @jeremyfrank! All that's needed is for you to comment in this PR with

I have read the DCO document and I hereby sign the DCO.

@kennylam
Copy link
Member

@jeremyfrank Thanks for this! Looks like you just need to sign the DCO (instructions in this comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants