fix: tooltip word break #18502
Merged
fix: tooltip word break #18502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18502 +/- ##
==========================================
- Coverage 84.16% 84.04% -0.12%
==========================================
Files 408 408
Lines 14450 14470 +20
Branches 4666 4680 +14
==========================================
Hits 12162 12162
- Misses 2123 2141 +18
- Partials 165 167 +2 ☔ View full report in Codecov by Sentry. |
kennylam
reviewed
Feb 7, 2025
Comment on lines
92
to
107
| export const Test = { | ||
| render: () => html` | ||
| <cds-tooltip align="bottom"> | ||
| <button | ||
| class="sb-tooltip-trigger" | ||
| role="button" | ||
| aria-labelledby="content"> | ||
| ${Information16()} | ||
| </button> | ||
| <cds-tooltip-content id="content"> | ||
| gfsghfsfsgggggghgsghsghgtuurutcxcrtstshgstsyststshsststststtstsffsfsgssjdstysyhgwtjyrkjgrutrwqtwyfyhygfhyiijfioyfdsrtkwjiutwjhqgwiyusrqjfterhtwgyqurtwu | ||
| </cds-tooltip-content> | ||
| </cds-tooltip> | ||
| `, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Yes this will be removed as mentioned in PR description.
emyarod
approved these changes
Feb 7, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 8, 2025
ca5f92f
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18161
Adds word-break support for tooltip content to handle long text without spaces
Changelog
Changed
word-break: break-wordto tooltip content styles to properly handle long text without spacesTesting / Reviewing
Steps to verify:
Go to Test story in tooltip word without space should not overflow , it should break.
Note- Test file will be deleted once the PR gets reviewed.