Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflow-menu): remove add from menu #2379

Merged
merged 2 commits into from
May 3, 2019

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented May 2, 2019

Closes #2248

Removes an incorrect example of having an Add + button in an OverflowMenu

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@asudoh asudoh merged commit 9f27de2 into carbon-design-system:master May 3, 2019
@asudoh
Copy link
Contributor

asudoh commented May 3, 2019

Oops missed visual review mark - My apologies. @jeanservaas I think the change is straightforward as this merely removes the usage pattern as you requested, but please don't hesitate to raise any concerns if there are. Thanks!

Copy link
Collaborator

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tw15egan tw15egan deleted the remove-add branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix[component]: Overflow menu
4 participants