-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications): fix pointer events for inline low contrast, update inverse link colors #4805
fix(notifications): fix pointer events for inline low contrast, update inverse link colors #4805
Conversation
Deploy preview for the-carbon-components ready! Built with commit 009ae2e https://deploy-preview-4805--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 009ae2e |
Deploy preview for carbon-components-react ready! Built with commit 75f3b92 https://deploy-preview-4805--carbon-components-react.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 009ae2e https://deploy-preview-4805--carbon-components-react.netlify.com |
Thanks for your notes on the colors @abbeyhrt & @joshblack! I updated the I also went ahead and added some hover and focus styles for links inside notifications... I realize it would be ideal if people passed in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you Jen!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think this looks good. No color change with just the added underline on hover is good.
Closes #4804
This PR fixes the pointer events issue identified in #4804 and seen on the
gatsby-theme-carbon
site by addingpointer-events: none
to the pseudo-selector:before
styles causing the problem.I also updated the storybook to add example links to both Notification components'
subtitle
prop, so that links can easily be checked in the future.Also in the process of doing this, I noticed that links passed into
title
orsubtitle
props aren't styled correctly with the$inverse-link
token, so I went ahead and added styles for that. I'm just not sure what hover/focus color you want for those links? Just let me know & I can update it 👍Changelog
New
$inverse-link
color tokens for links insideInlineNotification
andToastNotification
Changed
InlineNotification
, addpointer-events:none
to the pseudo:before
that covers the componentTesting / Reviewing
Make sure to select the
Low Contrast
knob in storybook. I definitely suggest comparing the deploy withInlineNotification
usage on thegatsby-theme-carbon
site 👍Also after you toggle on
Low Contrast
knob in this PR's storybook deploy, you can inspect the low-contrast:before
psuedo selector & comment out thepointer-events: none
style, then see if you can click on the link inside theInlineNotification
(you shouldn't be able to)