fix(DatePicker): fix calendar dropdown position #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change inroduces a Flatpickr plugin that ensures that the calendar dropdown is put in the correct floating position even if the floating menu container is changed via `appendTo` and the floating menu container has significant offset from `<body>`. Fixes carbon-design-system#4818.
|
Deploy preview for the-carbon-components ready! Built with commit 6a848ce https://deploy-preview-4846--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6a848ce |
|
Deploy preview for carbon-components-react ready! Built with commit 6a848ce https://deploy-preview-4846--carbon-components-react.netlify.com |
abbeyhrt
reviewed
Dec 12, 2019
| calendarContainer.style.top = `${refBottom - containerTop + 2}px`; | ||
| calendarContainer.style.left = `${refLeft - containerLeft}px`; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Hi @asudoh! I haven't worked much with positioning via javascript, could you explain what's going on here so I can learn a bit more about it? Thank you!
emyarod
approved these changes
Jan 9, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
…#4846) This change inroduces a Flatpickr plugin that ensures that the calendar dropdown is put in the correct floating position even if the floating menu container is changed via `appendTo` and the floating menu container has significant offset from `<body>`. Fixes carbon-design-system#4818.
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
…#4846) This change inroduces a Flatpickr plugin that ensures that the calendar dropdown is put in the correct floating position even if the floating menu container is changed via `appendTo` and the floating menu container has significant offset from `<body>`. Fixes carbon-design-system#4818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a Flatpickr plugin that ensures that the calendar dropdown is put in the correct floating position even if the floating menu container is changed via
appendToand the floating menu container has significant offset from<body>.Fixes #4818.
Changelog
New
appendToand the floating menu container has significant offset from<body>.Testing / Reviewing
Testing should make sure
<DatePicker>is not broken.