feat(file-uploader): add support for onChange #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements failed. Built with commit 0d82207 https://app.netlify.com/sites/carbon-elements/deploys/5dfa541e51c9a9000a02895f |
|
Deploy preview for the-carbon-components ready! Built with commit 0d82207 https://deploy-preview-4906--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 0d82207 https://deploy-preview-4906--carbon-components-react.netlify.com |
asudoh
approved these changes
Dec 17, 2019
aledavila
approved these changes
Dec 18, 2019
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going through the
FileUploaderstory, it seemed that we were callingthis.props.onChangeinhandleChangeunconditionally, even though this prop is not defined inpropTypesand has no default value. This PR updates to includeonChangeinpropTypesand conditionally calls it if it exists.Changelog
New
Changed
onChangetoFileUploader.propTypesand conditionally call it inhandleChangeRemoved
Testing / Reviewing